[HACK] Turn off inference mode in RL trainer for now #3440
+5
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running into this error when calling `aten.t()` on `Float8Tensor`: ``` RuntimeError: Cannot set version_counter for inference tensor ``` See pytorch/pytorch#164872
Datta0
reviewed
Nov 7, 2025
| # Cannot set version_counter for inference tensor | ||
| # Turning off inference mode for now | ||
| # See https://github.com/pytorch/pytorch/issues/164872 for more details | ||
| with torch.inference_mode(False): |
Collaborator
There was a problem hiding this comment.
Aren't we better off using no_grad here instead of completely disabling inference_mode @danielhanchen ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into this error when calling
aten.t()onFloat8Tensor:See pytorch/pytorch#164872